messaging-app

Merge lp:~canonical-platform-qa/messaging-app/more_helpers_test into lp:messaging-app

more_helpers_test
Merge into trunk

Proposed by Brendan Donegan on 2014-07-22

Status:	Needs review
Proposed branch:	lp:~canonical-platform-qa/messaging-app/more_helpers_test
Merge into:	lp:messaging-app
Diff against target:	55 lines (+18/-3) 2 files modified debian/control (+1/-0) tests/autopilot/messaging_app/tests/test_messaging.py (+17/-3)
To merge this branch:	bzr merge lp:~canonical-platform-qa/messaging-app/more_helpers_test
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Needs Fixing on 2014-08-14
Ubuntu Phablet Team		2014-07-22	Pending
Review via email: mp+227781@code.launchpad.net

Commit message

Add ContactListView and MultiRecipientInput custom proxy objects and a test for these

Description of the change

Add custom proxy objects for ContactListView and MultiRecipientInput, as well as a test to exercise these helpers.

This isn't ready to merge until we have a way to create a fake contact.

Revision history for this message

Brendan Donegan (brendan-donegan) wrote on 2014-07-31:

This is all ready to go now, but om26er's branch needs to land before it can work.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-13:

FAILED: Continuous integration, rev:160
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/380/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3463/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/2723/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-amd64-ci/174/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-armhf-ci/174/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-i386-ci/174/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4710/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3000/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/380/rebuild

review: Needs Fixing (continuous-integration)

lp:~canonical-platform-qa/messaging-app/more_helpers_test updated on 2014-08-13

161. By Brendan Donegan on 2014-08-13: Remove trailing whitespace

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-13:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/382/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-14:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/383/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-14:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/385/rebuild

review: Needs Fixing (continuous-integration)

lp:~canonical-platform-qa/messaging-app/more_helpers_test updated on 2014-08-14

162. By Brendan Donegan on 2014-08-14: Add dependency on address-book-service-testability

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-14:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/386/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-14:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/387/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

162. By Brendan Donegan on 2014-08-14: Add dependency on address-book-service-testability
161. By Brendan Donegan on 2014-08-13: Remove trailing whitespace
160. By Brendan Donegan on 2014-07-31: Merged from trunk
159. By Brendan Donegan on 2014-07-31: Finalize add contact from list helpers using om26ers fixture
158. By Brendan Donegan on 2014-07-22: Removed superflous get_recipients helper method
157. By Brendan Donegan on 2014-07-22: Refactor helpers and add a test for them
156. By I Ahmad on 2014-07-21: Added few more helpers after review comments
155. By Launchpad Translations on behalf of phablet-team on 2014-07-21: Launchpad automatic translations update.
154. By Launchpad Translations on behalf of phablet-team on 2014-07-20: Launchpad automatic translations update.
153. By Launchpad Translations on behalf of phablet-team on 2014-07-19: Launchpad automatic translations update.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

Subscribers

People subscribed via source and target branches

to all changes:

Canonical Platform QA Team

Sam Short

Ubuntu Phablet Team

1	=== modified file 'debian/control'
2	--- debian/control 2014-08-06 15:11:02 +0000
3	+++ debian/control 2014-08-14 07:50:58 +0000
4	@@ -41,6 +41,7 @@
5	Architecture: all
6	Section: debug
7	Depends: ${misc:Depends},
8	+ address-book-service-testability,
9	autopilot-qt5,
10	libqt5test5,
11	libqt5widgets5,
12
13	=== modified file 'tests/autopilot/messaging_app/tests/test_messaging.py'
14	--- tests/autopilot/messaging_app/tests/test_messaging.py 2014-08-01 19:40:26 +0000
15	+++ tests/autopilot/messaging_app/tests/test_messaging.py 2014-08-14 07:50:58 +0000
16	@@ -13,6 +13,7 @@
17
18	import subprocess
19	import time
20	+import address_book_service_testability.fixture_setup as addressbook_fixtures
21
22	from autopilot.matchers import Eventually
23	from testtools.matchers import Equals, HasLength
24	@@ -27,9 +28,8 @@
25	class BaseMessagingTestCase(MessagingAppTestCase):
26
27	def setUp(self):
28	-
29	- test_setup = fixture_setup.MessagingTestEnvironment()
30	- self.useFixture(test_setup)
31	+ self.useFixture(fixture_setup.MessagingTestEnvironment())
32	+ self.useFixture(addressbook_fixtures.AddressBookServiceDummyBackend())
33
34	super(BaseMessagingTestCase, self).setUp()
35
36	@@ -301,6 +301,20 @@
37	list_view = self.main_view.get_multiple_selection_list_view()
38	self.assertThat(list_view.count, Eventually(Equals(0)))
39
40	+ def test_add_contact_from_list(self):
41	+ """
42	+ Verify that we can add a contact to a message
43	+ by selecting it from a list.
44	+ """
45	+ self.main_view.start_new_message()
46	+ self.main_view.click_add_contact_icon()
47	+ contact_list = self.main_view.get_contact_list_view()
48	+ contact_list.select_contact_number(
49	+ 'UX User', '3333333'
50	+ )
51	+ recipients_input = self.main_view.get_newmessage_multirecipientinput()
52	+ self.assertIn('UX User', recipients_input.get_recipients())
53	+
54
55	class MessagingTestCaseWithExistingThread(BaseMessagingTestCase):
56