Code review comment for lp:~canonical-platform-qa/snappy-ecosystem-tests/snapd-staging-build-script

Revision history for this message
Santiago Baldassin (sbaldassin) wrote :

Looks better to me, however, there's an issue to be fixed.

By the way, I think the inheritance implemented in this mp is causing the issue in pylxd: https://github.com/lxc/pylxd/pull/220
If you tried the same sequence of events but without recreating the object, it is working just fine:
https://pastebin.ubuntu.com/23997027/

Last but not least, if you want to redefine the Container methods, like exec or delete, you'll have to do it in pylxd because they'll always use their class to create the objects. Another option is to move those methods to the builder and use the Container class provided by pylxd

review: Needs Fixing

« Back to merge proposal