Code review comment for lp:~canonical-platform-qa/snappy-ecosystem-tests/adding-test-runner

Revision history for this message
Heber Parrucci (heber013) wrote :

> I would suggest to not check in the credentials to the public bzr branch as
> bots can pick it up, this should be concealed using the environment variables
> or if we can find a way to encrypt them at check in time and decrypt it when
> these were needed for the setup (like travis)

Thanks for review!

Now credentials are read from a user config file that is outside the repo in the host machine. If that config is not found, then it reads the credentials from env variables.
The idea is to store the config with the credentials in a private repository, and then Jenkins will get it and store in the host machine when running the tests.
The same mechanism is used in ubuntu-system-tests.

« Back to merge proposal