Code review comment for lp:~canonical-platform-qa/snappy-ecosystem-tests/adding-ssh-client-driver

Revision history for this message
Heber Parrucci (heber013) wrote :

> Looks good in general. Minor comment inline
Applies the same response that for Omer:
We are going to run the tests over internet in the future for devices like: raspberry Pi, dragonboards, etc. And those devices will be on the lab (at least for running tests on Jenkins). In those cases we have to ensure that every time we execute a command over ssh, the connection is active.
That's why we cannot save the SshClient instance in the helpers, because we cannot ask to the client itself to get an active connection in every command execution.
The driver was created to resolve that problem. You store an instance in your helper and then execute commands, for every command you execute, it ensures that the ssh connection for that client is active by requesting the manager.
How can we achieve that using the SshClient instead of the driver?

« Back to merge proposal