Code review comment for lp:~canonical-platform-qa/snappy-ecosystem-tests/adding-ssh-client-driver

Revision history for this message
Omer Akram (om26er) wrote :

Excuse my ignorance, can you tell what problem this branch tries to solve ? From the look of it, it seems to be making things more complex. The SSHClientDriver is now the only consumer of SSHManager.

I do see the SSHClientDriver gets a connected instance from the manager each time a command is run, this does solve a problem, though that will only be relevant if our tests were running over the internet, right now they are running on the local network.

Do you know if in future our tests will be running over the internet instead of the local network where the risk of ssh connection drop practically diminishes.

review: Needs Information

« Back to merge proposal