Merge lp:~canonical-platform-qa/qakit/fix_config into lp:qakit

Proposed by Santiago Baldassin
Status: Merged
Approved by: Sergio Cazzolato
Approved revision: 158
Merged at revision: 158
Proposed branch: lp:~canonical-platform-qa/qakit/fix_config
Merge into: lp:qakit
Diff against target: 88 lines (+11/-41)
4 files modified
qakit/config.py (+10/-0)
qakit/config/__init__.py (+0/-14)
qakit/config/config.py (+0/-26)
qakit/ust/worker.py (+1/-1)
To merge this branch: bzr merge lp:~canonical-platform-qa/qakit/fix_config
Reviewer Review Type Date Requested Status
Sergio Cazzolato Approve
Review via email: mp+305874@code.launchpad.net

Commit message

Fixing the config conflicts

Description of the change

Fixing the config conflicts

To post a comment you must log in.
Revision history for this message
Sergio Cazzolato (sergio-j-cazzolato) wrote :

code lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== removed directory 'qakit/config'
=== modified file 'qakit/config.py'
--- qakit/config.py 2016-01-26 13:22:00 +0000
+++ qakit/config.py 2016-09-15 19:34:18 +0000
@@ -18,6 +18,7 @@
18"""Functions for configuration parsing."""18"""Functions for configuration parsing."""
1919
20import os.path20import os.path
21from configparser import ConfigParser
2122
2223
23def get_config_file_location():24def get_config_file_location():
@@ -25,3 +26,12 @@
25 QAKIT_CONFIG env variable is defined, it is be used, otherwise it is26 QAKIT_CONFIG env variable is defined, it is be used, otherwise it is
26 used the default config file in .config dir"""27 used the default config file in .config dir"""
27 return os.getenv('QAKIT_CONFIG', os.path.expanduser('~/.config/qakit.ini'))28 return os.getenv('QAKIT_CONFIG', os.path.expanduser('~/.config/qakit.ini'))
29
30
31class Config:
32
33 def __init__(self):
34 self.parser = ConfigParser()
35 conf_file = os.getenv('QAKIT_CONFIG',
36 os.path.expanduser('~/.config/qakit.ini'))
37 self.parser.read(conf_file)
28\ No newline at end of file38\ No newline at end of file
2939
=== removed file 'qakit/config/__init__.py'
--- qakit/config/__init__.py 2016-09-03 11:30:49 +0000
+++ qakit/config/__init__.py 1970-01-01 00:00:00 +0000
@@ -1,14 +0,0 @@
1# Copyright (C) 2016 Canonical
2#
3# This program is free software: you can redistribute it and/or modify
4# it under the terms of the GNU General Public License as published by
5# the Free Software Foundation, either version 3 of the License, or
6# (at your option) any later version.
7#
8# This program is distributed in the hope that it will be useful,
9# but WITHOUT ANY WARRANTY; without even the implied warranty of
10# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11# GNU General Public License for more details.
12#
13# You should have received a copy of the GNU General Public License
14# along with this program. If not, see <http://www.gnu.org/licenses/>.
150
=== removed file 'qakit/config/config.py'
--- qakit/config/config.py 2016-09-06 12:05:20 +0000
+++ qakit/config/config.py 1970-01-01 00:00:00 +0000
@@ -1,26 +0,0 @@
1# Copyright (C) 2016 Canonical
2#
3# This program is free software: you can redistribute it and/or modify
4# it under the terms of the GNU General Public License as published by
5# the Free Software Foundation, either version 3 of the License, or
6# (at your option) any later version.
7#
8# This program is distributed in the hope that it will be useful,
9# but WITHOUT ANY WARRANTY; without even the implied warranty of
10# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11# GNU General Public License for more details.
12#
13# You should have received a copy of the GNU General Public License
14# along with this program. If not, see <http://www.gnu.org/licenses/>.
15
16import os
17from configparser import ConfigParser
18
19
20class Config:
21
22 def __init__(self):
23 self.parser = ConfigParser()
24 conf_file = os.getenv('QAKIT_CONFIG',
25 os.path.expanduser('~/.config/qakit.ini'))
26 self.parser.read(conf_file)
270
=== modified file 'qakit/ust/worker.py'
--- qakit/ust/worker.py 2016-09-15 18:35:45 +0000
+++ qakit/ust/worker.py 2016-09-15 19:34:18 +0000
@@ -19,7 +19,7 @@
19from pika import BlockingConnection19from pika import BlockingConnection
20from pika import ConnectionParameters20from pika import ConnectionParameters
2121
22from qakit.config.config import Config22from qakit.config import Config
23from qakit.launchpad.ppa import Ppa23from qakit.launchpad.ppa import Ppa
24from qakit.practitest.practitest import PractitestSession24from qakit.practitest.practitest import PractitestSession
2525

Subscribers

People subscribed via source and target branches

to all changes: