Merge lp:~canonical-platform-qa/qakit/fix_config into lp:qakit

Proposed by Santiago Baldassin
Status: Merged
Approved by: Sergio Cazzolato
Approved revision: 158
Merged at revision: 158
Proposed branch: lp:~canonical-platform-qa/qakit/fix_config
Merge into: lp:qakit
Diff against target: 88 lines (+11/-41)
4 files modified
qakit/config.py (+10/-0)
qakit/config/__init__.py (+0/-14)
qakit/config/config.py (+0/-26)
qakit/ust/worker.py (+1/-1)
To merge this branch: bzr merge lp:~canonical-platform-qa/qakit/fix_config
Reviewer Review Type Date Requested Status
Sergio Cazzolato Approve
Review via email: mp+305874@code.launchpad.net

Commit message

Fixing the config conflicts

Description of the change

Fixing the config conflicts

To post a comment you must log in.
Revision history for this message
Sergio Cazzolato (sergio-j-cazzolato) wrote :

code lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed directory 'qakit/config'
2=== modified file 'qakit/config.py'
3--- qakit/config.py 2016-01-26 13:22:00 +0000
4+++ qakit/config.py 2016-09-15 19:34:18 +0000
5@@ -18,6 +18,7 @@
6 """Functions for configuration parsing."""
7
8 import os.path
9+from configparser import ConfigParser
10
11
12 def get_config_file_location():
13@@ -25,3 +26,12 @@
14 QAKIT_CONFIG env variable is defined, it is be used, otherwise it is
15 used the default config file in .config dir"""
16 return os.getenv('QAKIT_CONFIG', os.path.expanduser('~/.config/qakit.ini'))
17+
18+
19+class Config:
20+
21+ def __init__(self):
22+ self.parser = ConfigParser()
23+ conf_file = os.getenv('QAKIT_CONFIG',
24+ os.path.expanduser('~/.config/qakit.ini'))
25+ self.parser.read(conf_file)
26\ No newline at end of file
27
28=== removed file 'qakit/config/__init__.py'
29--- qakit/config/__init__.py 2016-09-03 11:30:49 +0000
30+++ qakit/config/__init__.py 1970-01-01 00:00:00 +0000
31@@ -1,14 +0,0 @@
32-# Copyright (C) 2016 Canonical
33-#
34-# This program is free software: you can redistribute it and/or modify
35-# it under the terms of the GNU General Public License as published by
36-# the Free Software Foundation, either version 3 of the License, or
37-# (at your option) any later version.
38-#
39-# This program is distributed in the hope that it will be useful,
40-# but WITHOUT ANY WARRANTY; without even the implied warranty of
41-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
42-# GNU General Public License for more details.
43-#
44-# You should have received a copy of the GNU General Public License
45-# along with this program. If not, see <http://www.gnu.org/licenses/>.
46
47=== removed file 'qakit/config/config.py'
48--- qakit/config/config.py 2016-09-06 12:05:20 +0000
49+++ qakit/config/config.py 1970-01-01 00:00:00 +0000
50@@ -1,26 +0,0 @@
51-# Copyright (C) 2016 Canonical
52-#
53-# This program is free software: you can redistribute it and/or modify
54-# it under the terms of the GNU General Public License as published by
55-# the Free Software Foundation, either version 3 of the License, or
56-# (at your option) any later version.
57-#
58-# This program is distributed in the hope that it will be useful,
59-# but WITHOUT ANY WARRANTY; without even the implied warranty of
60-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
61-# GNU General Public License for more details.
62-#
63-# You should have received a copy of the GNU General Public License
64-# along with this program. If not, see <http://www.gnu.org/licenses/>.
65-
66-import os
67-from configparser import ConfigParser
68-
69-
70-class Config:
71-
72- def __init__(self):
73- self.parser = ConfigParser()
74- conf_file = os.getenv('QAKIT_CONFIG',
75- os.path.expanduser('~/.config/qakit.ini'))
76- self.parser.read(conf_file)
77
78=== modified file 'qakit/ust/worker.py'
79--- qakit/ust/worker.py 2016-09-15 18:35:45 +0000
80+++ qakit/ust/worker.py 2016-09-15 19:34:18 +0000
81@@ -19,7 +19,7 @@
82 from pika import BlockingConnection
83 from pika import ConnectionParameters
84
85-from qakit.config.config import Config
86+from qakit.config import Config
87 from qakit.launchpad.ppa import Ppa
88 from qakit.practitest.practitest import PractitestSession
89

Subscribers

People subscribed via source and target branches

to all changes: