Dekko

Merge lp:~canonical-platform-qa/dekko/add_object_names_part1 into lp:~dpniel/dekko/trunk2

  1. add_object_names_part1
  2. Merge into trunk2
Proposed by Omer Akram
Status: Needs review
Proposed branch: lp:~canonical-platform-qa/dekko/add_object_names_part1
Merge into: lp:~dpniel/dekko/trunk2
Diff against target: 130 lines (+13/-1)
8 files modified
qml/MessageListView/MessageListPage.qml (+1/-0)
qml/SetupWizard/CredentialValidation.qml (+1/-0)
qml/SetupWizard/DetailsInput.qml (+2/-1)
qml/SetupWizard/IdentityInput.qml (+1/-0)
qml/SetupWizard/NewAccountPage.qml (+2/-0)
qml/SetupWizard/NewAccountTypeListView.qml (+1/-0)
qml/SetupWizard/NoAccountsPage.qml (+2/-0)
qml/SetupWizard/UserInput.qml (+3/-0)
To merge this branch: bzr merge lp:~canonical-platform-qa/dekko/add_object_names_part1
Reviewer Review Type Date Requested Status
Dan Chapman  Pending
Review via email: mp+291044@code.launchpad.net

Commit message

Add objectNames to be used for autopilot testing

Description of the change

Add objectNames to be used for autopilot testing in the lp:ubuntu-system-tests project

Note: this is just an initial set of objectNames, required for a test I am working on, I will create more pull requests as the need arise.

To post a comment you must log in.
lp:~canonical-platform-qa/dekko/add_object_names_part1 updated
739. By Omer Akram

right place

740. By Omer Akram

Add objectName for credentials verification screen

Unmerged revisions

740. By Omer Akram

Add objectName for credentials verification screen

739. By Omer Akram

right place

738. By Omer Akram

Add initial set of objectNames

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'qml/MessageListView/MessageListPage.qml'
--- qml/MessageListView/MessageListPage.qml 2016-02-08 12:36:26 +0000
+++ qml/MessageListView/MessageListPage.qml 2016-04-06 05:45:04 +0000
@@ -29,6 +29,7 @@
2929
30DekkoPage {30DekkoPage {
31 id: messageListPage31 id: messageListPage
32 objectName: "emailListPage"
32 pageTitle: dekko.currentAccount.msgListModel.unreadCount ? qsTr("Inbox %1").arg(dekko.currentAccount.msgListModel.unreadCount ) : qsTr("Inbox")33 pageTitle: dekko.currentAccount.msgListModel.unreadCount ? qsTr("Inbox %1").arg(dekko.currentAccount.msgListModel.unreadCount ) : qsTr("Inbox")
3334
34 function updateTitle() {35 function updateTitle() {
3536
=== modified file 'qml/SetupWizard/CredentialValidation.qml'
--- qml/SetupWizard/CredentialValidation.qml 2016-02-08 12:36:25 +0000
+++ qml/SetupWizard/CredentialValidation.qml 2016-04-06 05:45:04 +0000
@@ -20,6 +20,7 @@
2020
21ProcessingOverlay {21ProcessingOverlay {
22 id: credentialValidation22 id: credentialValidation
23 objectName: "credentialValidation"
2324
24 signal failedWithErrorMessage(string message)25 signal failedWithErrorMessage(string message)
2526
2627
=== modified file 'qml/SetupWizard/DetailsInput.qml'
--- qml/SetupWizard/DetailsInput.qml 2016-02-08 12:36:26 +0000
+++ qml/SetupWizard/DetailsInput.qml 2016-04-06 05:45:04 +0000
@@ -24,8 +24,9 @@
2424
25Item {25Item {
26 id: userInput26 id: userInput
27 objectName: "accountDetailExtraScreen"
27 anchors.fill: parent28 anchors.fill: parent
2829
29 signal back()30 signal back()
30 signal inputComplete()31 signal inputComplete()
3132
3233
=== modified file 'qml/SetupWizard/IdentityInput.qml'
--- qml/SetupWizard/IdentityInput.qml 2016-02-08 12:36:26 +0000
+++ qml/SetupWizard/IdentityInput.qml 2016-04-06 05:45:04 +0000
@@ -24,6 +24,7 @@
2424
25Item {25Item {
26 id: userInput26 id: userInput
27 objectName: "userIdentityInputScreen"
27 anchors.fill: parent28 anchors.fill: parent
2829
29 signal back()30 signal back()
3031
=== modified file 'qml/SetupWizard/NewAccountPage.qml'
--- qml/SetupWizard/NewAccountPage.qml 2016-02-08 12:36:26 +0000
+++ qml/SetupWizard/NewAccountPage.qml 2016-04-06 05:45:04 +0000
@@ -22,6 +22,7 @@
2222
23Page {23Page {
24 id: newAccountPage24 id: newAccountPage
25 objectName: "accountTypeListPage"
25 flickable: null26 flickable: null
26 signal next()27 signal next()
27 signal createNewOA()28 signal createNewOA()
@@ -36,6 +37,7 @@
36 }37 }
3738
38 NewAccountTypeListView {39 NewAccountTypeListView {
40 objectName: "accountTypeList"
39 anchors {41 anchors {
40 top: header.bottom42 top: header.bottom
41 left: parent.left43 left: parent.left
4244
=== modified file 'qml/SetupWizard/NewAccountTypeListView.qml'
--- qml/SetupWizard/NewAccountTypeListView.qml 2016-02-08 12:36:26 +0000
+++ qml/SetupWizard/NewAccountTypeListView.qml 2016-04-06 05:45:04 +0000
@@ -48,6 +48,7 @@
48 // }48 // }
4949
50 delegate: AccountsDrawerDelegate {50 delegate: AccountsDrawerDelegate {
51 objectName: "newAccountListItem_" + model.serviceName
51 text: description52 text: description
52 iconSource: model.icon53 iconSource: model.icon
53 onClicked: {54 onClicked: {
5455
=== modified file 'qml/SetupWizard/NoAccountsPage.qml'
--- qml/SetupWizard/NoAccountsPage.qml 2016-02-08 12:36:26 +0000
+++ qml/SetupWizard/NoAccountsPage.qml 2016-04-06 05:45:04 +0000
@@ -23,6 +23,7 @@
2323
24Item {24Item {
25 id: accountsPage25 id: accountsPage
26 objectName: "noAccountsPage"
26 anchors.fill: parent27 anchors.fill: parent
2728
28 DekkoHeader {29 DekkoHeader {
@@ -57,6 +58,7 @@
5758
58 Button {59 Button {
59 id: btn60 id: btn
61 objectName "addAccountButton"
60 anchors {62 anchors {
61 top: emptyState.bottom63 top: emptyState.bottom
62 topMargin: units.gu(4)64 topMargin: units.gu(4)
6365
=== modified file 'qml/SetupWizard/UserInput.qml'
--- qml/SetupWizard/UserInput.qml 2016-02-08 12:36:26 +0000
+++ qml/SetupWizard/UserInput.qml 2016-04-06 05:45:04 +0000
@@ -23,6 +23,7 @@
2323
24Item {24Item {
25 id: userInput25 id: userInput
26 objectName: "usernamePasswordArea"
26 anchors.fill: parent27 anchors.fill: parent
2728
28 signal back()29 signal back()
@@ -153,6 +154,7 @@
153 spacing: units.gu(1)154 spacing: units.gu(1)
154 TitledTextField {155 TitledTextField {
155 id: emailField156 id: emailField
157 objectName: "emailField"
156 text: wizard.accountType === NewAccountType.SMTP ? wizard.account.smtpSettings.username : wizard.account.imapSettings.username158 text: wizard.accountType === NewAccountType.SMTP ? wizard.account.smtpSettings.username : wizard.account.imapSettings.username
157 requiredField: nonValidUsernameField159 requiredField: nonValidUsernameField
158 inputMethodHints: Qt.ImhNoAutoUppercase | Qt.ImhEmailCharactersOnly | Qt.ImhNoPredictiveText160 inputMethodHints: Qt.ImhNoAutoUppercase | Qt.ImhEmailCharactersOnly | Qt.ImhNoPredictiveText
@@ -171,6 +173,7 @@
171173
172 TitledTextField {174 TitledTextField {
173 id: passwordField175 id: passwordField
176 objectName: "passwordField"
174 title: qsTr("Password")177 title: qsTr("Password")
175 text: wizard.tempPasswordStore178 text: wizard.tempPasswordStore
176 inputMethodHints: Qt.ImhHiddenText | Qt.ImhNoAutoUppercase | Qt.ImhNoPredictiveText179 inputMethodHints: Qt.ImhHiddenText | Qt.ImhNoAutoUppercase | Qt.ImhNoPredictiveText

Subscribers

People subscribed via source and target branches