Merge lp:~canonical-platform-qa/autopilot/pdf-build into lp:autopilot

Proposed by Allan LeSage
Status: Needs review
Proposed branch: lp:~canonical-platform-qa/autopilot/pdf-build
Merge into: lp:autopilot
Diff against target: 96 lines (+17/-6)
3 files modified
debian/control (+3/-0)
debian/rules (+9/-1)
docs/man.rst (+5/-5)
To merge this branch: bzr merge lp:~canonical-platform-qa/autopilot/pdf-build
Reviewer Review Type Date Requested Status
platform-qa-bot continuous-integration Approve
PS Jenkins bot continuous-integration Approve
Martin Pitt (community) Needs Fixing
Thomi Richards (community) Approve
Review via email: mp+247249@code.launchpad.net

Commit message

Provide pdf build.

Description of the change

Provide pdf-building via LaTeX.

Required minor modification for a unicode char unprovided-for. Where/how would we want to install the result?

This'll be on hold until I fix a noodly Makefile/bash issue (marked as FIXME in debian/rules), but wanting to get some feedback.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
530. By Allan LeSage

Correct .svg extensions.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
531. By Allan LeSage

Revert whitespace change.

532. By Allan LeSage

Makefile hackery to convert .svgs to .pdf, revert wildcard .svg change, add imagemagick build-dep.

533. By Allan LeSage

Merge trunk.

534. By Allan LeSage

Clean up debian/rules comments :/ .

Revision history for this message
Allan LeSage (allanlesage) wrote :

To build/test, just do a normal debian build--the .pdf arrives in build/sphinx/latex/Autopilot.pdf , else just follow the steps listed in debian/rules. Note that you'll need the added dependencies.

Also note that the man.rst changes convert that unicode em-dash to a normal hyphen, wasn't supported during the LaTeX generation.

535. By Allan LeSage

debian/control whitespace fix.

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

LGTM, but I'd like to see someone review the packaging bits.

Cheers,

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Martin Pitt (pitti) wrote :

The packaging in debian/rules looks fine to me. However, it fails to build:

   debian/rules override_dh_auto_build
make[1]: Entering directory '/«BUILDDIR»/autopilot-1.5.0+14.10.20140806'
convert /«BUILDDIR»/autopilot-1.5.0+14.10.20140806/docs/images/test_pyramid.svg /«BUILDDIR»/autopilot-1.5.0+14.10.20140806/docs/images/test_pyramid.pdf
convert: delegate failed `"rsvg-convert" -o "%o" "%i"' @ error/delegate.c/InvokeDelegate/1310.
convert: unable to open image `/tmp/magick-28976RCFje6T2VDtX': No such file or directory @ error/blob.c/OpenBlob/2709.
convert: unable to open file `/tmp/magick-28976RCFje6T2VDtX': No such file or directory @ error/constitute.c/ReadImage/540.
convert: no images defined `/«BUILDDIR»/autopilot-1.5.0+14.10.20140806/docs/images/test_pyramid.pdf' @ error/convert.c/ConvertImageCommand/3210.
make[1]: *** [/«BUILDDIR»/autopilot-1.5.0+14.10.20140806/docs/images/test_pyramid.pdf] Error 1
debian/rules:8: recipe for target '/«BUILDDIR»/autopilot-1.5.0+14.10.20140806/docs/images/test_pyramid.pdf' failed
make[1]: Leaving directory '/«BUILDDIR»/autopilot-1.5.0+14.10.20140806'
make: *** [build] Error 2
debian/rules:14: recipe for target 'build' failed

Maybe that's still missing some build dep?

I can't quite see what changed in docs/man.rst, that seems to be some whitespace noise?

review: Needs Fixing
536. By Allan LeSage

Add librsvg2-bin build-dep.

Revision history for this message
Allan LeSage (allanlesage) wrote :

Mysterious missing dependency; this builds under pbuilder; we'll wait for Jenkins' approval--thanks for your notes pitti.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

The jenkins node for the amd64 build failed, I've restarted a new ci run.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:536
http://jenkins.qa.ubuntu.com/job/autopilot-ci/1007/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-amd64-ci/70
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-amd64-ci/70/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-armhf-ci/70
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-armhf-ci/70/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-i386-ci/70
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-i386-ci/70/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1003
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid-autopilot/100
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/888
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1001
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1001/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17473
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid-autopilot/97
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/570
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/570/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/1007/rebuild

review: Approve (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Unsure as to why there are newline changes in docs/man.rst. But otherwise, LGTM. Did you find texlive-fonts-recommended required? Is our font special?

Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :
review: Approve (continuous-integration)

Unmerged revisions

536. By Allan LeSage

Add librsvg2-bin build-dep.

535. By Allan LeSage

debian/control whitespace fix.

534. By Allan LeSage

Clean up debian/rules comments :/ .

533. By Allan LeSage

Merge trunk.

532. By Allan LeSage

Makefile hackery to convert .svgs to .pdf, revert wildcard .svg change, add imagemagick build-dep.

531. By Allan LeSage

Revert whitespace change.

530. By Allan LeSage

Correct .svg extensions.

529. By Allan LeSage

Provide for pdf in debian-build.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2014-10-30 08:10:12 +0000
+++ debian/control 2015-01-23 16:16:27 +0000
@@ -11,9 +11,11 @@
11 gir1.2-ibus-1.0,11 gir1.2-ibus-1.0,
12 gir1.2-ubuntu-app-launch-2 | gir1.2-upstart-app-launch-2,12 gir1.2-ubuntu-app-launch-2 | gir1.2-upstart-app-launch-2,
13 graphviz,13 graphviz,
14 imagemagick,
14 libjs-jquery,15 libjs-jquery,
15 libjs-underscore,16 libjs-underscore,
16 liblttng-ust-dev,17 liblttng-ust-dev,
18 librsvg2-bin,
17 python3-all-dev (>= 3.4),19 python3-all-dev (>= 3.4),
18 python3-dateutil,20 python3-dateutil,
19 python3-dbus,21 python3-dbus,
@@ -32,6 +34,7 @@
32 python3-testtools,34 python3-testtools,
33 python3-xlib,35 python3-xlib,
34 sphinx-common,36 sphinx-common,
37 texlive-fonts-recommended,
35 texlive-latex-extra,38 texlive-latex-extra,
36Standards-Version: 3.9.539Standards-Version: 3.9.5
37Homepage: https://launchpad.net/autopilot40Homepage: https://launchpad.net/autopilot
3841
=== modified file 'debian/rules' (properties changed: -x to +x)
--- debian/rules 2014-07-23 03:37:24 +0000
+++ debian/rules 2015-01-23 16:16:27 +0000
@@ -4,6 +4,12 @@
4# Uncomment this to turn on verbose mode.4# Uncomment this to turn on verbose mode.
5# export DH_VERBOSE=15# export DH_VERBOSE=1
66
7%.pdf : %.svg
8 convert $< $@
9
10# find .svgs, make list of .pdfs to generate
11PDFs := $(patsubst %.svg,%.pdf,$(wildcard $(CURDIR)/docs/images/*.svg))
12
7%:13%:
8 dh $@ --with python3,sphinxdoc --buildsystem=pybuild14 dh $@ --with python3,sphinxdoc --buildsystem=pybuild
915
@@ -11,11 +17,13 @@
11 # https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=74569017 # https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=745690
12 -dh_sphinxdoc18 -dh_sphinxdoc
1319
14override_dh_auto_build:20override_dh_auto_build: $(PDFs)
15 python3 -m flake8.run .21 python3 -m flake8.run .
16 dh_auto_build22 dh_auto_build
17 python3 setup.py build_sphinx -b html23 python3 setup.py build_sphinx -b html
18 python3 setup.py build_sphinx -b man24 python3 setup.py build_sphinx -b man
25 python3 setup.py build_sphinx -b latex
26 $(MAKE) -C $(CURDIR)/build/sphinx/latex all-pdf
1927
20override_dh_auto_test:28override_dh_auto_test:
21ifeq (, $(findstring nocheck, $(DEB_BUILD_OPTIONS)))29ifeq (, $(findstring nocheck, $(DEB_BUILD_OPTIONS)))
2230
=== modified file 'docs/man.rst'
--- docs/man.rst 2015-01-21 05:28:45 +0000
+++ docs/man.rst 2015-01-23 16:16:27 +0000
@@ -16,8 +16,8 @@
16General Options16General Options
17 -h, --help17 -h, --help
18 Get help from autopilot. This command can also be present after a18 Get help from autopilot. This command can also be present after a
19 sub-command (such as run or list) to get help on the specific com‐19 sub-command (such as run or list) to get help on the specific com-
20 mand. Further options are restricted to particular autopilot com‐20 mand. Further options are restricted to particular autopilot com-
21 mands.21 mands.
2222
23 -v, --version23 -v, --version
@@ -35,7 +35,7 @@
35 See `SPECIFYING SUITES`_35 See `SPECIFYING SUITES`_
3636
37 -ro, --run-order37 -ro, --run-order
38 List tests in the order they will be run in, rather than alphabet‐38 List tests in the order they will be run in, rather than alphabet-
39 ically (which is the default).39 ically (which is the default).
4040
41 --suites41 --suites
@@ -49,7 +49,7 @@
4949
50 -o FILE, --output FILE50 -o FILE, --output FILE
51 Specify where the test log should be written. Defaults to stdout.51 Specify where the test log should be written. Defaults to stdout.
52 If a directory is specified the file will be created with a file‐52 If a directory is specified the file will be created with a file-
53 name of <hostname>_<dd.mm.yyy_HHMMSS>.log53 name of <hostname>_<dd.mm.yyy_HHMMSS>.log
5454
55 -f FORMAT, --format FORMAT55 -f FORMAT, --format FORMAT
@@ -60,7 +60,7 @@
60 Stop the test run on the first error or failure.60 Stop the test run on the first error or failure.
6161
62 -r, --record62 -r, --record
63 Record failed tests. Using this option requires the 'recordmydesk‐63 Record failed tests. Using this option requires the 'recordmydesk-
64 top' application be installed. By default, videos are stored in64 top' application be installed. By default, videos are stored in
65 /tmp/autopilot65 /tmp/autopilot
6666

Subscribers

People subscribed via source and target branches