Code review comment for lp:~canonical-platform-qa/autopilot/cpo-base-classes-fix

Revision history for this message
Christopher Lee (veebers) wrote :

I'm really not a fan of modifying the classes in such a way, perhaps it's indicating that we're going down the wrong path and we need to find a better solution.

That being said the 2 tests that failed due to _try_custom_proxy_classes raising an exception [1] (the 3rd not being related) shows that the warning re: base CPO classes not being passed in correctly.

I'm just trying to get my local devices etc. setup so I can test this, but I think that if we instead change the warning to an error (yes, I was wrong there it should have always been an error :-) ). and use the updated addresss book (i.e. the one that is passing the correct base_emulator in aka Leos branch) we shouldn't need to modify the class attributes like we are here.

I'll try to post the results when I get them, but at this rate it's going to take ages (my device is acting up.)

[1] http://q-jenkins.ubuntu-ci:8080/job/autopilot-release-gatekeeper/263/label=daily-mako/testReport/

review: Needs Information

« Back to merge proposal