Merge ~canonical-kernel-team/+git/autotest-client-tests:phlin/header-first into ~canonical-kernel-team/+git/autotest-client-tests:master

Proposed by Po-Hsu Lin
Status: Merged
Merge reported by: Po-Hsu Lin
Merged at revision: e26725276f8c4eae7f07e6a2a9e5df39c70a3bfa
Proposed branch: ~canonical-kernel-team/+git/autotest-client-tests:phlin/header-first
Merge into: ~canonical-kernel-team/+git/autotest-client-tests:master
Diff against target: 49 lines (+16/-0)
3 files modified
ubuntu_bpf/ubuntu_bpf.py (+5/-0)
ubuntu_kernel_selftests/ubuntu_kernel_selftests.py (+6/-0)
ubuntu_kselftests_ftrace/ubuntu_kselftests_ftrace.py (+5/-0)
Reviewer Review Type Date Requested Status
Sean Feole Approve
Francis Ginther Approve
Review via email: mp+449259@code.launchpad.net

Commit message

BugLink: https://bugs.launchpad.net/bugs/2031400

Tests from kernel selftest now require header files to be built first.

This affects:
* ubuntu_kernel_selftests
* ubuntu_bpf
* ubuntu_kselftest_ftrace

Run the make header command during setup phase, so that we just need
to run it once.

To post a comment you must log in.
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

This is hindering test build on Xenial, maybe we should limit this make header thing to newer kernels (jammy+)

Revision history for this message
Francis Ginther (fginther) wrote :

+1

review: Approve
Revision history for this message
Sean Feole (sfeole) wrote :

+1

review: Approve
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Applied and pushed. Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/ubuntu_bpf/ubuntu_bpf.py b/ubuntu_bpf/ubuntu_bpf.py
index 0c52a7e..516bc58 100644
--- a/ubuntu_bpf/ubuntu_bpf.py
+++ b/ubuntu_bpf/ubuntu_bpf.py
@@ -43,6 +43,11 @@ class ubuntu_bpf(test.test):
43 else:43 else:
44 pkgs.extend(['clang', 'llvm', 'lld'])44 pkgs.extend(['clang', 'llvm', 'lld'])
4545
46 # Build header first (LP: #2031400)
47 if not self.series in ['trusty', 'xenial', 'bionic', 'focal']:
48 cmd = "make -C linux/ headers"
49 utils.system_output(cmd, retain_output=True)
50
46 cmd = 'yes "" | DEBIAN_FRONTEND=noninteractive apt-get install --yes --force-yes ' + ' '.join(pkgs)51 cmd = 'yes "" | DEBIAN_FRONTEND=noninteractive apt-get install --yes --force-yes ' + ' '.join(pkgs)
47 self.results = utils.system_output(cmd, retain_output=True)52 self.results = utils.system_output(cmd, retain_output=True)
4853
diff --git a/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py b/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
index 23269c4..496099b 100644
--- a/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
+++ b/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
@@ -220,6 +220,12 @@ class ubuntu_kernel_selftests(test.test):
220 cmd = 'sed -i "/^TEST_PROGS += txtimestamp.sh$/d" ' + fn220 cmd = 'sed -i "/^TEST_PROGS += txtimestamp.sh$/d" ' + fn
221 utils.system(cmd)221 utils.system(cmd)
222222
223 # Build header first (LP: #2031400)
224 if not self.series in ['trusty', 'xenial', 'bionic', 'focal']:
225 cmd = "make -C linux/ headers"
226 utils.system_output(cmd, retain_output=True)
227
228
223 def run_once(self, test_name):229 def run_once(self, test_name):
224 if test_name == 'setup':230 if test_name == 'setup':
225 return231 return
diff --git a/ubuntu_kselftests_ftrace/ubuntu_kselftests_ftrace.py b/ubuntu_kselftests_ftrace/ubuntu_kselftests_ftrace.py
index 0f14def..74d5c0c 100644
--- a/ubuntu_kselftests_ftrace/ubuntu_kselftests_ftrace.py
+++ b/ubuntu_kselftests_ftrace/ubuntu_kselftests_ftrace.py
@@ -84,6 +84,11 @@ class ubuntu_kselftests_ftrace(test.test):
84 if os.path.exists(fn):84 if os.path.exists(fn):
85 os.remove(fn)85 os.remove(fn)
8686
87 # Build header first (LP: #2031400)
88 if not self.series in ['trusty', 'xenial', 'bionic', 'focal']:
89 cmd = "make -C linux/ headers"
90 utils.system_output(cmd, retain_output=True)
91
8792
88 def run_once(self, test_name):93 def run_once(self, test_name):
89 if test_name == 'setup':94 if test_name == 'setup':

Subscribers

People subscribed via source and target branches

to all changes: