Code review comment for lp:~canonical-isd-hackers/ubuntu-webcatalog/useragent_778562

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Hey Danny! I was just pulling this up to find out why it hadn't landed yet (argh, conflicts), but noticed that you're not grabbing the distroseries from the user-agent when present... just wondering why?

Here's a screenshot showing Ubuntu/11.04 for me with chromium:
http://people.canonical.com/~michaeln/tmp/778562-headers.png

It won't be available in all browsers, but those that are patched by ubuntu should have it.

I really don't think we should be guessing at all, as it could provide a very confusing user experience. Either we know their distroseries and take advantage of that, or we don't and do some baseline functionality.

« Back to merge proposal