- tiny stylistic issue: we prefer singular assertion methods (assertEqual)
- l. 249: always use RequestContext, otherwise context processors won't be applied (you won't get a style page for example)
One last question: given that there were certain precautions not to break the openid dance in this view, are we certain not redirecting will keep those scenarios working?
I like avoiding the use of session for this (+1)
- tiny stylistic issue: we prefer singular assertion methods (assertEqual)
- l. 249: always use RequestContext, otherwise context processors won't be applied (you won't get a style page for example)
One last question: given that there were certain precautions not to break the openid dance in this view, are we certain not redirecting will keep those scenarios working?