Code review comment for lp:~canonical-isd-hackers/canonical-identity-provider/fix-tests

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

The acceptance suite is failing with:

======================================================================
ERROR: test_add_device_google (sst.runtests.TestAdd_Device_Google)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/nessita/canonical/cip/reviews/.env/local/lib/python2.7/site-packages/sst/runtests.py", line 284, in test
    exec self.code in context
  File "/home/nessita/canonical/cip/reviews/identityprovider/tests/acceptance/devices/add_device_google.py", line 37, in <module>
    aes_key = get_key_from_qrcode(email)
  File "/home/nessita/canonical/cip/reviews/identityprovider/tests/acceptance/shared/devices.py", line 176, in get_key_from_qrcode
    b32_key = parse_qs(otpauth.query)['secret'][0]
KeyError: 'secret'

----------------------------------------------------------------------
Ran 1 test in 10.644s

FAILED (errors=1)
----------------------------------------------------------------------

I think that failure is related to the changes done in this branch, so I think it needs some fixing. Please let me know if I need to tweak something else in my env.

review: Needs Fixing

« Back to merge proposal