Merge lp:~canonical-isd-hackers/canonical-identity-provider/email_screen into lp:~canonical-isd-hackers/canonical-identity-provider/stable

Proposed by David Owen
Status: Merged
Merged at revision: 41
Proposed branch: lp:~canonical-isd-hackers/canonical-identity-provider/email_screen
Merge into: lp:~canonical-isd-hackers/canonical-identity-provider/stable
Diff against target: 51 lines (+7/-5)
3 files modified
doctests/stories/sso-server/standalone-login.txt (+1/-1)
identityprovider/templates/account/emails.html (+6/-3)
identityprovider/templates/widgets/ubuntu/logout-button.html (+0/-1)
To merge this branch: bzr merge lp:~canonical-isd-hackers/canonical-identity-provider/email_screen
Reviewer Review Type Date Requested Status
Ricardo Kirkner (community) Approve
Review via email: mp+30138@code.launchpad.net

Description of the change

Changes navigation to and from the email addresses screen, according to Stuart's suggestion in the bug report.

To post a comment you must log in.
Revision history for this message
Ricardo Kirkner (ricardokirkner) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'doctests/stories/sso-server/standalone-login.txt'
--- doctests/stories/sso-server/standalone-login.txt 2010-07-12 22:49:50 +0000
+++ doctests/stories/sso-server/standalone-login.txt 2010-07-16 18:57:40 +0000
@@ -212,7 +212,7 @@
212212
213 >>> def add_email(browser, email):213 >>> def add_email(browser, email):
214 ... browser.open('http://openid.launchpad.dev/+edit')214 ... browser.open('http://openid.launchpad.dev/+edit')
215 ... browser.getLink('Email addresses').click()215 ... browser.getLink('Manage email addresses').click()
216 ... browser.getControl(name='newemail').value = email216 ... browser.getControl(name='newemail').value = email
217 ... browser.getControl(name='continue').click()217 ... browser.getControl(name='continue').click()
218218
219219
=== modified file 'identityprovider/templates/account/emails.html'
--- identityprovider/templates/account/emails.html 2010-07-13 15:48:43 +0000
+++ identityprovider/templates/account/emails.html 2010-07-16 18:57:40 +0000
@@ -1,9 +1,11 @@
1<!-- Copyright 2010 Canonical Ltd. This software is licensed under the
2GNU Affero General Public License version 3 (see the file LICENSE). -->
3
4{% extends "base.html" %}1{% extends "base.html" %}
5{% load i18n %}2{% load i18n %}
63
4{% comment %}
5Copyright 2010 Canonical Ltd. This software is licensed under the
6GNU Affero General Public License version 3 (see the file LICENSE).
7{% endcomment %}
8
7{% block title %}9{% block title %}
8 {% blocktrans %}{{ account_displayname }}'s email addresses{% endblocktrans %}10 {% blocktrans %}{{ account_displayname }}'s email addresses{% endblocktrans %}
9{% endblock %}11{% endblock %}
@@ -95,6 +97,7 @@
95 <button type="submit" class="btn" name="continue">97 <button type="submit" class="btn" name="continue">
96 <span><span>{% trans "Add address" %}</span></span>98 <span><span>{% trans "Add address" %}</span></span>
97 </button>99 </button>
100 {% blocktrans %}or <a href="/">cancel</a>{% endblocktrans %}
98 </p>101 </p>
99 </form>102 </form>
100103
101104
=== modified file 'identityprovider/templates/widgets/ubuntu/logout-button.html'
--- identityprovider/templates/widgets/ubuntu/logout-button.html 2010-07-13 16:15:10 +0000
+++ identityprovider/templates/widgets/ubuntu/logout-button.html 2010-07-16 18:57:40 +0000
@@ -9,7 +9,6 @@
9<ul>9<ul>
1010
11{% menu_item "account" user.displayname "/" %}11{% menu_item "account" user.displayname "/" %}
12{% menu_item "emails" _("Email addresses") "/+emails" %}
1312
14{% if token and not readonly %}13{% if token and not readonly %}
15 {% menu_item "edit" _("Edit") "./+edit" %}14 {% menu_item "edit" _("Edit") "./+edit" %}

Subscribers

People subscribed via source and target branches

to all changes: