Merge lp:~canonical-isd-hackers/canonical-identity-provider/bug_495006 into lp:canonical-identity-provider/release

Proposed by David Owen
Status: Merged
Merged at revision: 48
Proposed branch: lp:~canonical-isd-hackers/canonical-identity-provider/bug_495006
Merge into: lp:canonical-identity-provider/release
Diff against target: 108 lines (+45/-8)
4 files modified
doctests/stories/sso-server/prefilled-email.txt (+29/-0)
identityprovider/templates/launchpad/registration/login.html (+2/-2)
identityprovider/templates/ubuntu/registration/login.html (+2/-2)
identityprovider/views/ui.py (+12/-4)
To merge this branch: bzr merge lp:~canonical-isd-hackers/canonical-identity-provider/bug_495006
Reviewer Review Type Date Requested Status
Danny Tamez (community) Approve
Review via email: mp+25804@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Danny Tamez (zematynnad) wrote :

Great job David

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file 'doctests/stories/sso-server/prefilled-email.txt'
--- doctests/stories/sso-server/prefilled-email.txt 1970-01-01 00:00:00 +0000
+++ doctests/stories/sso-server/prefilled-email.txt 2010-05-21 21:14:29 +0000
@@ -0,0 +1,29 @@
1Copyright 2010 Canonical Ltd. This software is licensed under the
2GNU Affero General Public License version 3 (see the file LICENSE).
3
4= Pre-fill e-mail addresses on forms =
5
6If the user has attempted a login (and failed), we would like to use
7the e-mail provided to pre-fill other forms.
8
9== "Forgot Password" form ==
10
11 >>> browser = setupBrowser()
12 >>> browser.open('http://openid.launchpad.dev')
13 >>> browser.getControl(name='email').value = 'new-user@example.com'
14 >>> browser.getControl(name='continue').click()
15 >>> browser.getLink('Forgot your password?').click()
16 >>> print browser.getControl(name='email').value
17 new-user@example.com
18
19
20== "New Account" form ==
21
22 >>> browser = setupBrowser()
23 >>> browser.open('http://openid.launchpad.dev')
24 >>> browser.getControl(name='email').value = 'new-user@example.com'
25 >>> browser.getControl(name='continue').click()
26 >>> browser.getLink('New account').click()
27 >>> print browser.getControl(name='email').value
28 new-user@example.com
29
030
=== modified file 'identityprovider/templates/launchpad/registration/login.html'
--- identityprovider/templates/launchpad/registration/login.html 2010-05-13 16:01:26 +0000
+++ identityprovider/templates/launchpad/registration/login.html 2010-05-21 21:14:29 +0000
@@ -39,12 +39,12 @@
39 {% if form.non_field_errors %}<span class="error">{{ form.non_field_errors|join:"" }}</span>{% endif %}39 {% if form.non_field_errors %}<span class="error">{{ form.non_field_errors|join:"" }}</span>{% endif %}
40 <br />40 <br />
41{% if not readonly %}41{% if not readonly %}
42 <a href="+forgot_password" id="forgotpw-link">{% trans "Forgot your password?" %}</a>42 <a href="+forgot_password{% if form.email.data %}?email={{ form.email.data|urlencode }}{% endif %}" id="forgotpw-link">{% trans "Forgot your password?" %}</a>
43{% endif %}43{% endif %}
44 </p>44 </p>
45{% if not readonly %}45{% if not readonly %}
46 <p>46 <p>
47 <a href="+new_account" class="btn alt"><span><span>{% trans "Create a new account" %}</span></span></a>47 <a href="+new_account{% if form.email.data %}?email={{ form.email.data|urlencode }}{% endif %}" class="btn alt"><span><span>{% trans "Create a new account" %}</span></span></a>
48 </p>48 </p>
49{% endif %}49{% endif %}
50 <div class="actions">50 <div class="actions">
5151
=== modified file 'identityprovider/templates/ubuntu/registration/login.html'
--- identityprovider/templates/ubuntu/registration/login.html 2010-05-13 16:01:26 +0000
+++ identityprovider/templates/ubuntu/registration/login.html 2010-05-21 21:14:29 +0000
@@ -44,7 +44,7 @@
44 {% if form.non_field_errors %}<span class="error">{{ form.non_field_errors|join:"" }}</span>{% endif %}44 {% if form.non_field_errors %}<span class="error">{{ form.non_field_errors|join:"" }}</span>{% endif %}
45 <br />45 <br />
46{% if not readonly %}46{% if not readonly %}
47 <a href="+forgot_password" id="forgotpw-link">{% trans "Forgot your password?" %}</a>47 <a href="+forgot_password{% if form.email.data %}?email={{ form.email.data|urlencode }}{% endif %}" id="forgotpw-link">{% trans "Forgot your password?" %}</a>
48{% endif %}48{% endif %}
49 </p>49 </p>
5050
@@ -73,7 +73,7 @@
73 </p>73 </p>
74{% if not readonly %}74{% if not readonly %}
75 <p>75 <p>
76 <a href="+new_account" class="btn alt"><span><span>{% trans "New account" %}</span></span></a>76 <a href="+new_account{% if form.email.data %}?email={{ form.email.data|urlencode }}{% endif %}" class="btn alt"><span><span>{% trans "New account" %}</span></span></a>
77 </p>77 </p>
78{% endif %}78{% endif %}
79{% endblock %}79{% endblock %}
8080
=== modified file 'identityprovider/views/ui.py'
--- identityprovider/views/ui.py 2010-05-13 16:01:26 +0000
+++ identityprovider/views/ui.py 2010-05-21 21:14:29 +0000
@@ -123,8 +123,12 @@
123@guest_required123@guest_required
124@check_readonly124@check_readonly
125def new_account(request, token=None):125def new_account(request, token=None):
126 form = NewAccountForm()126 if request.method == 'GET':
127 if request.method == 'POST':127 if 'email' in request.GET:
128 form = NewAccountForm(initial={'email': request.GET['email']})
129 else:
130 form = NewAccountForm()
131 elif request.method == 'POST':
128 form = NewAccountForm(request.POST)132 form = NewAccountForm(request.POST)
129 if form.is_valid():133 if form.is_valid():
130134
@@ -330,8 +334,12 @@
330@guest_required334@guest_required
331@check_readonly335@check_readonly
332def forgot_password(request, token=None):336def forgot_password(request, token=None):
333 form = ForgotPasswordForm()337 if request.method == 'GET':
334 if request.method == 'POST':338 if 'email' in request.GET:
339 form = ForgotPasswordForm(initial={'email': request.GET['email']})
340 else:
341 form = ForgotPasswordForm()
342 elif request.method == 'POST':
335 form = ForgotPasswordForm(request.POST)343 form = ForgotPasswordForm(request.POST)
336 if form.is_valid():344 if form.is_valid():
337 response = _verify_captcha_response(345 response = _verify_captcha_response(