Merge ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:vicamo/for-hwe/sync-debian-7858-deb1 into ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:ubuntu/master

Proposed by You-Sheng Yang
Status: Merged
Approved by: You-Sheng Yang
Approved revision: ab9b717c3a3225d2d3ec674571fb7c65a82d9f9f
Merged at revision: ab9b717c3a3225d2d3ec674571fb7c65a82d9f9f
Proposed branch: ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:vicamo/for-hwe/sync-debian-7858-deb1
Merge into: ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:ubuntu/master
Diff against target: 76 lines (+31/-2)
6 files modified
debian/changelog (+8/-0)
debian/gbp.conf (+1/-0)
debian/patches/0001-keep-zconf-in-make-clean.patch (+19/-0)
debian/patches/series (+1/-0)
debian/rules (+1/-1)
debian/source/format (+1/-1)
Reviewer Review Type Date Requested Status
You-Sheng Yang Approve
Anthony Wong Needs Fixing
Review via email: mp+369282@code.launchpad.net

Description of the change

* Fix build on recent kernel that removes *.lex.c and *.tab.c at clean stage.
* Switch to non-native build.

To post a comment you must log in.
Revision history for this message
You-Sheng Yang (vicamo) wrote :
Revision history for this message
You-Sheng Yang (vicamo) wrote :
Revision history for this message
You-Sheng Yang (vicamo) :
review: Needs Fixing
Revision history for this message
You-Sheng Yang (vicamo) wrote :

Rebuild with updated HEAD passed in all series.

review: Approve
Revision history for this message
Anthony Wong (anthonywong) wrote :

Just a minor fix needed in debian/patches/0001-keep-zconf-in-make-clean.patch, otherwise looks good. Thanks.

review: Needs Fixing
Revision history for this message
You-Sheng Yang (vicamo) wrote :

> Just a minor fix needed in debian/patches/0001-keep-zconf-in-make-clean.patch,
> otherwise looks good. Thanks.

Addressed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index f6dc7d4..d70c99a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
1backport-iwlwifi-dkms (7858-ubuntu2) UNRELEASED; urgency=low
2
3 * Fix build on recent kernel that removes *.lex.c and *.tab.c at clean
4 stage.
5 * Switch to non-native build.
6
7 -- You-Sheng Yang <vicamo@gmail.com> Tue, 25 Jun 2019 18:41:42 +0800
8
1backport-iwlwifi-dkms (7858-ubuntu1) UNRELEASED; urgency=low9backport-iwlwifi-dkms (7858-ubuntu1) UNRELEASED; urgency=low
210
3 * sync with debian 7858.11 * sync with debian 7858.
diff --git a/debian/gbp.conf b/debian/gbp.conf
index accc13f..fca26f6 100644
--- a/debian/gbp.conf
+++ b/debian/gbp.conf
@@ -1,3 +1,4 @@
1[DEFAULT]1[DEFAULT]
2debian-branch = debian/master2debian-branch = debian/master
3upstream-branch = upstream/master3upstream-branch = upstream/master
4upstream-tree = BRANCH
diff --git a/debian/patches/0001-keep-zconf-in-make-clean.patch b/debian/patches/0001-keep-zconf-in-make-clean.patch
4new file mode 1006445new file mode 100644
index 0000000..2af7729
--- /dev/null
+++ b/debian/patches/0001-keep-zconf-in-make-clean.patch
@@ -0,0 +1,19 @@
1Description: Keep kconf/zconf.{lex,tab}.c during "make clean"
2Author: Anthony Wong <anthony.wong@canonical.com>
3Forwarded: https://www.spinics.net/lists/backports/msg04856.html
4Last-Update: 2019-06-22
5---
6This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
7--- a/Makefile.real
8+++ b/Makefile.real
9@@ -127,7 +127,10 @@
10 @echo Reboot.
11 @echo
12
13+EXCLUDE_CLEAN := kconf/zconf.lex.c kconf/zconf.tab.c
14 .PHONY: clean
15 clean:
16+ @$(foreach f, $(EXCLUDE_CLEAN), mv $(f) $(f).orig;)
17 @$(MAKE) -f Makefile.build clean
18 @$(MAKE) -C kconf clean
19+ @$(foreach f, $(EXCLUDE_CLEAN), mv $(f).orig $(f);)
diff --git a/debian/patches/series b/debian/patches/series
index e69de29..118ab0e 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -0,0 +1 @@
10001-keep-zconf-in-make-clean.patch
diff --git a/debian/rules b/debian/rules
index b3eefb4..429ab0d 100755
--- a/debian/rules
+++ b/debian/rules
@@ -10,7 +10,7 @@ GENERATED_DKMS_FILES= \
10 debian/backport-iwlwifi-dkms.dkms10 debian/backport-iwlwifi-dkms.dkms
1111
12%:12%:
13 dh $@ --with dkms,modaliases,quilt13 dh $@ --with dkms,modaliases
1414
15override_dh_auto_configure:15override_dh_auto_configure:
16override_dh_auto_build:16override_dh_auto_build:
diff --git a/debian/source/format b/debian/source/format
index 89ae9db..163aaf8 100644
--- a/debian/source/format
+++ b/debian/source/format
@@ -1 +1 @@
13.0 (native)13.0 (quilt)

Subscribers

People subscribed via source and target branches