Merge ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:vicamo/for-hwe/sync-debian-7858-deb1 into ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:ubuntu/master

Proposed by You-Sheng Yang
Status: Merged
Approved by: You-Sheng Yang
Approved revision: ab9b717c3a3225d2d3ec674571fb7c65a82d9f9f
Merged at revision: ab9b717c3a3225d2d3ec674571fb7c65a82d9f9f
Proposed branch: ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:vicamo/for-hwe/sync-debian-7858-deb1
Merge into: ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:ubuntu/master
Diff against target: 76 lines (+31/-2)
6 files modified
debian/changelog (+8/-0)
debian/gbp.conf (+1/-0)
debian/patches/0001-keep-zconf-in-make-clean.patch (+19/-0)
debian/patches/series (+1/-0)
debian/rules (+1/-1)
debian/source/format (+1/-1)
Reviewer Review Type Date Requested Status
You-Sheng Yang Approve
Anthony Wong Needs Fixing
Review via email: mp+369282@code.launchpad.net

Description of the change

* Fix build on recent kernel that removes *.lex.c and *.tab.c at clean stage.
* Switch to non-native build.

To post a comment you must log in.
Revision history for this message
You-Sheng Yang (vicamo) wrote :
Revision history for this message
You-Sheng Yang (vicamo) wrote :
Revision history for this message
You-Sheng Yang (vicamo) :
review: Needs Fixing
Revision history for this message
You-Sheng Yang (vicamo) wrote :

Rebuild with updated HEAD passed in all series.

review: Approve
Revision history for this message
Anthony Wong (anthonywong) wrote :

Just a minor fix needed in debian/patches/0001-keep-zconf-in-make-clean.patch, otherwise looks good. Thanks.

review: Needs Fixing
Revision history for this message
You-Sheng Yang (vicamo) wrote :

> Just a minor fix needed in debian/patches/0001-keep-zconf-in-make-clean.patch,
> otherwise looks good. Thanks.

Addressed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index f6dc7d4..d70c99a 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+backport-iwlwifi-dkms (7858-ubuntu2) UNRELEASED; urgency=low
7+
8+ * Fix build on recent kernel that removes *.lex.c and *.tab.c at clean
9+ stage.
10+ * Switch to non-native build.
11+
12+ -- You-Sheng Yang <vicamo@gmail.com> Tue, 25 Jun 2019 18:41:42 +0800
13+
14 backport-iwlwifi-dkms (7858-ubuntu1) UNRELEASED; urgency=low
15
16 * sync with debian 7858.
17diff --git a/debian/gbp.conf b/debian/gbp.conf
18index accc13f..fca26f6 100644
19--- a/debian/gbp.conf
20+++ b/debian/gbp.conf
21@@ -1,3 +1,4 @@
22 [DEFAULT]
23 debian-branch = debian/master
24 upstream-branch = upstream/master
25+upstream-tree = BRANCH
26diff --git a/debian/patches/0001-keep-zconf-in-make-clean.patch b/debian/patches/0001-keep-zconf-in-make-clean.patch
27new file mode 100644
28index 0000000..2af7729
29--- /dev/null
30+++ b/debian/patches/0001-keep-zconf-in-make-clean.patch
31@@ -0,0 +1,19 @@
32+Description: Keep kconf/zconf.{lex,tab}.c during "make clean"
33+Author: Anthony Wong <anthony.wong@canonical.com>
34+Forwarded: https://www.spinics.net/lists/backports/msg04856.html
35+Last-Update: 2019-06-22
36+---
37+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
38+--- a/Makefile.real
39++++ b/Makefile.real
40+@@ -127,7 +127,10 @@
41+ @echo Reboot.
42+ @echo
43+
44++EXCLUDE_CLEAN := kconf/zconf.lex.c kconf/zconf.tab.c
45+ .PHONY: clean
46+ clean:
47++ @$(foreach f, $(EXCLUDE_CLEAN), mv $(f) $(f).orig;)
48+ @$(MAKE) -f Makefile.build clean
49+ @$(MAKE) -C kconf clean
50++ @$(foreach f, $(EXCLUDE_CLEAN), mv $(f).orig $(f);)
51diff --git a/debian/patches/series b/debian/patches/series
52index e69de29..118ab0e 100644
53--- a/debian/patches/series
54+++ b/debian/patches/series
55@@ -0,0 +1 @@
56+0001-keep-zconf-in-make-clean.patch
57diff --git a/debian/rules b/debian/rules
58index b3eefb4..429ab0d 100755
59--- a/debian/rules
60+++ b/debian/rules
61@@ -10,7 +10,7 @@ GENERATED_DKMS_FILES= \
62 debian/backport-iwlwifi-dkms.dkms
63
64 %:
65- dh $@ --with dkms,modaliases,quilt
66+ dh $@ --with dkms,modaliases
67
68 override_dh_auto_configure:
69 override_dh_auto_build:
70diff --git a/debian/source/format b/debian/source/format
71index 89ae9db..163aaf8 100644
72--- a/debian/source/format
73+++ b/debian/source/format
74@@ -1 +1 @@
75-3.0 (native)
76+3.0 (quilt)

Subscribers

People subscribed via source and target branches