Code review comment for lp:~canonical-dx-team/unity/unity.qlmenuitems

Revision history for this message
Neil J. Patel (njpatel) wrote :

Looks much clearer, some remaining issues:

- Conflict with trunk (as discussed)

- Still multiple implementations of DrawText, should be one implementation in QuicklistMenuItem that has enough options that all the sub-classes can use it

- GetTextExtents has the same issue as DrawText, multiple implementations, should be in QuicklistMenuitem class

- Use GtkSettings to also get the current font name of the desktop

- There are multiple implementations of DrawRoundedRectangle too

review: Needs Fixing

« Back to merge proposal