Code review comment for lp:~canonical-ci-engineering/uci-engine/nfss
Revision history for this message
| Thomi Richards (thomir-deactivatedaccount) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Various replies to various people:
Francis: As discussed on IRC, the fact that we're using python 3 means that integrating with the run-tests command isn't possible right now. However, I have made sure that doing 'python setup.py test' installs all the test dependencies (although there's a problem on some machines with the psycopg2 package from pypi).
WRT hosting static content separately, I'd like it to remain in the same source tree. Beyond that, I don't have anything intelligent to say on the topic. Please advise if you want any changes made.
WRT moving the API to be /nfss/api/v1 - surely that will require changes to the client-side UI as well? It's trivial to change the routing rules in pyramid (it's literally a 1 line change in __init__.py), I just want to make sure that we don't break things down the line.
Andy: The mock dependency has been removed - thanks for pointing out that it exists in python 3.4.