Code review comment for lp:~canonical-ci-engineering/ubuntu-ci-services-itself/pm

Revision history for this message
Francis Ginther (fginther) wrote :

In general this is all good for phase 0, I don't see anything missing.

Just some small nit-picking:
 - For "submitting a file to project manager" would it be easier to state the format needed (yaml, json, etc.) and the required keys?
 - The Interactions/Ticket System reflects the older design. Might just want to focus on the Phase 0 plan of interacting with the Lander and the UI.
 - I can't think of an immediate need to have multiple users defined for phase 0. But I can see the potential need for having at least a default user defined.

As these don't appear to directly impact the design, I'll approve.

review: Approve

« Back to merge proposal