Code review comment for lp:~canonical-ci-engineering/charms/trusty/core-result-checker/test-with-relations

Revision history for this message
Celso Providelo (cprov) wrote :

Thomi,

As discussed on HO (me, Francis and you), the symlinks do not match our expectation from ServiceManager() [1], something does not fit well. Also we have experienced success with `juju destroy-service ...` last Friday.

There might be, as you suggested, some weird timing issues around this that we cannot easily reproduce.

From everything you have tried, I am ok for you to land this in the snappy-proposed-result-checker charm branch and experiment with reaper.py calling (and waiting) destroy-services before destroying the juju env.

If we get it to work, we can quickly propagate this other snappy-proposed charms

[1] https://pythonhosted.org/charmhelpers/examples/services.html

review: Approve

« Back to merge proposal