Ubuntu Apps Directory

Code review comment for lp:~canonical-ca-hackers/ubuntu-webcatalog/965473-none-in-the-url

  1. 965473-none-in-the-url
  2. Merge into trunk
Revision history for this message
Michael Nelson (michael.nelson) wrote :

13:28 < noodles> lukasz: could thee test on linee 14 do self.assertContains(response, 'href="/cat/applications/whatever') instead of assertNotContains?
13:33 < lukasz> noodles, sure, but why?
13:34 < noodles> lukasz: because asserting that something isn't contained in the result can lead to very easy false positives (ie. the link is moved to a different template)

Thanks for the updated test!

review: Approve

« Back to merge proposal