Code review comment for lp:~canonical-ca-hackers/ubuntu-webcatalog/1006362-remove-maverick-add-quantal

Revision history for this message
Anthony Lenton (elachuni) wrote :

Hi Łukasz,

Looks good! Another minor improvement: import_ratings_stats, import_exhibits, import_for_purchase_apps and import_app_install_data all create DistroSeries objects if they don't find one in the DB, but they do so with the information they find available at the time, which I think is always only the code_name, not the version. Could you use the UBUNTU_SERIES_FOR_VERSIONS setting to create DistroSeries always with the right value for both fields? (If you think this is something for a separate branch, I'm happy to land this as is!)

achuni.

review: Approve

« Back to merge proposal