As the rewrite to reactive is basically a complete charm re-build, can we have this merge against an empty feature/version branch rather than against master for a review w/out all the charmhelpers removes/etc?
I think we need a pointer in this MR to either a bug or a spec you're writing against to discuss more in depth the requirements vs. the code.
I also don't see the reactive/handlers.py file because the MR cut it short...see suggestion regarding an MR against a blank feature branch.
A few comments inline.
As the rewrite to reactive is basically a complete charm re-build, can we have this merge against an empty feature/version branch rather than against master for a review w/out all the charmhelpers removes/etc?
I think we need a pointer in this MR to either a bug or a spec you're writing against to discuss more in depth the requirements vs. the code.
I also don't see the reactive/ handlers. py file because the MR cut it short...see suggestion regarding an MR against a blank feature branch.