charm-openstack-service-checks

Code review comment for ~canonical-bootstack/charm-openstack-service-checks:check-loadbalancers

  1. Git
  2. lp:~canonical-bootstack/charm-openstack-service-checks
  3. check-loadbalancers
  4. Merge into master
Revision history for this message
Joe Guo (guoqiao) wrote :

Hi Alvaro,
Thanks for the review.
For 2), I can set it to False.
For 1) 3), they are issues from existing functional test, not related to this patch, maybe we can create a separate bug for that?

« Back to merge proposal