Stock And Logistic Flows

Code review comment for lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde

  1. 7.0-picking_dispatch_wave-according-defined-number-of-sales_rde
  2. Merge into 7.0
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

Needs fixing:

* convert the description in __openerp__.py to Restructured Text
* please add a test
* I'm concerned the SQL query may bypass the multicompany security rules
* NEVER DO SQL PARAMETER SUBSTITUTION WITH THE % OPERATOR!!!!

review: Needs Fixing (code review, no test)

« Back to merge proposal