Merge lp:~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge into lp:~sale-core-editors/sale-wkfl/7.0
Proposed by
Yannick Vaucher @ Camptocamp
Status: | Merged |
---|---|
Merged at revision: | 44 |
Proposed branch: | lp:~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge |
Merge into: | lp:~sale-core-editors/sale-wkfl/7.0 |
Diff against target: |
182 lines (+156/-0) 5 files modified
sale_jit_on_services/__init__.py (+22/-0) sale_jit_on_services/__openerp__.py (+60/-0) sale_jit_on_services/procurement.py (+36/-0) sale_jit_on_services/procurement_workflow.xml (+14/-0) sale_jit_on_services/test/sale_service_jit_test.yml (+24/-0) |
To merge this branch: | bzr merge lp:~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sandy Carter (http://www.savoirfairelinux.com) | Approve | ||
Yannick Vaucher @ Camptocamp | Abstain | ||
Guewen Baconnier @ Camptocamp | code review | Approve | |
Nicolas Bessi - Camptocamp | code review, no test | Pending | |
Review via email: mp+214719@code.launchpad.net |
This proposal supersedes a proposal from 2013-12-13.
Description of the change
[ADD] sale_jit_
This allow to have SO marked as delivered without waiting the mrp
I resubmit as it was rewritten using workflows
To post a comment you must log in.
Just wondering if the logging is supposed to be there or just there for debugging purposes.
If that's the case, you might want to remove it.
Some PEP8 issues: _.py:32: 84: W291 trailing whitespace _.py:39: 78: W291 trailing whitespace _.py:49: 29: E202 whitespace before ']' _.py:52: 13: E126 continuation line over-indented for hanging indent py:19:75: W291 trailing whitespace py:33:75: W291 trailing whitespace
__init__.py:3:2: W291 trailing whitespace
__init__.py:19:75: W291 trailing whitespace
__openerp_
__openerp_
__openerp_
__openerp_
sale_stock.py:3:2: W291 trailing whitespace
sale_stock.
sale_stock.py:28:1: E302 expected 2 blank lines, found 1
sale_stock.
Typos:
__openerp__.py:36: In word 'Usualy'
sale_stock.py:39: In word 'ommitted'
Unused imports:
sale_stock.py:23: fields