Code review comment for lp:~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge
Revision history for this message
| Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote | # |
review:
Needs Information
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Joël,
The "mrp_jit" module uses a different approach: it modifies the condition of the workflow.
Did you do it this way to ensure compatibility when both modules are installed?
I may be wrong but I wonder if the condition on l.152 should not restrict only on 'service' *and* 'buy' so if the 'project_mrp' module is used, the 'produce service' would still be triggered by the scheduler.