Code review comment for lp:~camptocamp/sale-reports/sale-reports-add-so-webkit

Revision history for this message
Niels Huylebroeck (red15) wrote :

Considering the changes in the v7 for the partner address it would be advised to also use the date formatting as used in the default sale order.

In the sale/report/sale_report.rml we can see that instead of showing the street/zip/city/country individually they simply call 'display_adress(address_id)' which takes care of using the formatting as specify on the country of your own company (not necessarily the best method I can think of but it's still better than doing this manually in each report)

Considering the blocking nature of this merge I will give it approve and try to merge it, I just thought it could help you guys in the future for more compatibility with the rest of openerp.

review: Approve

« Back to merge proposal