Merge lp:~camptocamp/sale-reports/7.0-sync-sale_order_webkit_with_invoice_webkit-20130607 into lp:~sale-core-editors/sale-reports/7.0

Proposed by Yannick Vaucher @ Camptocamp
Status: Merged
Merged at revision: 21
Proposed branch: lp:~camptocamp/sale-reports/7.0-sync-sale_order_webkit_with_invoice_webkit-20130607
Merge into: lp:~sale-core-editors/sale-reports/7.0
Diff against target: 195 lines (+62/-102)
1 file modified
sale_order_webkit/report/sale_order.mako (+62/-102)
To merge this branch: bzr merge lp:~camptocamp/sale-reports/7.0-sync-sale_order_webkit_with_invoice_webkit-20130607
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp code review, test Approve
Guewen Baconnier @ Camptocamp code review, no test Approve
Review via email: mp+168055@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

review: Approve (code review, no test)
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

works fine

review: Approve (code review, test)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'sale_order_webkit/report/sale_order.mako'
--- sale_order_webkit/report/sale_order.mako 2013-05-22 14:26:07 +0000
+++ sale_order_webkit/report/sale_order.mako 2013-06-07 13:16:47 +0000
@@ -8,91 +8,43 @@
8 text-align:center;8 text-align:center;
9 border-collapse: collapse;9 border-collapse: collapse;
10}10}
1111.list_sale_table th {
12 background-color: #EEEEEE;
13 border: thin solid #000000;
14 text-align:center;
15 font-size:12;
16 font-weight:bold;
17 padding-right:3px;
18 padding-left:3px;
19}
12.list_sale_table td {20.list_sale_table td {
21 border-top: thin solid #EEEEEE;
22 text-align:left;
23 font-size:12;
24 padding-right:3px;
25 padding-left:3px;
26 padding-top:3px;
27 padding-bottom:3px;
28}
29.list_sale_table thead {
30 display:table-header-group;
31}
32
33td.formatted_note {
34 text-align:left;
35 border-right:thin solid #EEEEEE;
36 border-left:thin solid #EEEEEE;
13 border-top:thin solid #EEEEEE;37 border-top:thin solid #EEEEEE;
14 text-align:right;38 padding-left:10px;
15 font-size:12;39 font-size:11;
16 padding-right:3px;40}
17 padding-left:3px;41
18 padding-top:3px;42
19 padding-bottom:3px;
20}
21
22.list_bank_table {
23 text-align:center;
24 border-collapse: collapse;
25}
26
27.list_bank_table td {
28 text-align:left;
29 font-size:12;
30 padding-right:3px;
31 padding-left:3px;
32 padding-top:3px;
33 padding-bottom:3px;
34}
35
36.list_bank_table th {
37 background-color: #EEEEEE;
38 text-align:left;
39 font-size:12;
40 font-weight:bold;
41 padding-right:3px
42 padding-left:3px
43}
44
45.list_sale_table th {
46 background-color: #EEEEEE;
47 border: thin solid #000000;
48 text-align:center;
49 font-size:12;
50 font-weight:bold;
51 padding-right:3px;
52 padding-left:3px;
53}
54
55.list_table thead {
56 display:table-header-group;
57}
58
59
60.list_tax_table {
61}
62.list_tax_table td {
63 text-align:left;
64 font-size:12;
65}
66
67
68.list_table thead {
69 display:table-header-group;
70}
71
72
73.list_total_table {
74 border-collapse: collapse;
75}
76
77.list_total_table td {
78 text-align:right;
79 font-size:12;
80}
8143
82.no_bloc {44.no_bloc {
83 border-top: thin solid #ffffff ;45 border-top: thin solid #ffffff ;
84}46}
8547
86
87.list_total_table th {
88 background-color: #F7F7F7;
89 border-collapse: collapse;
90}
91
92tfoot.totals tr:first-child td{
93 padding-top: 15px;
94}
95
96.right_table {48.right_table {
97 right: 4cm;49 right: 4cm;
98 width:"100%";50 width:"100%";
@@ -102,14 +54,20 @@
102 font-size:12;54 font-size:12;
103}55}
10456
105.note {57tfoot.totals tr:first-child td{
106 text-align:left;58 padding-top: 15px;
107 font-size:10;59}
108 border-top:thin solid #ffffff;60
109 border-left:thin solid #ffffff;61
110 border-right:thin solid #ffffff;62td.amount, th.amount {
111}63 text-align: right;
11264 white-space: nowrap;
65}
66
67
68.address .recipient .shipping .invoice {
69 font-size: 12px;
70}
11371
114 </style>72 </style>
115</head>73</head>
@@ -207,22 +165,24 @@
207 </tr>165 </tr>
208 </thead>166 </thead>
209 <tbody>167 <tbody>
210 %for line in order.order_line:168 %for line in order.order_line:
211 <tr class="line">169 <tr class="line">
212 <td style="text-align:left; " >${ line.name }</td>170 <td style="text-align:left; " >${ line.name }</td>
213 <td class="amount" width="7.5%">${ formatLang(line.product_uos and line.product_uos_qty or line.product_uom_qty) }</td>171 <td class="amount" width="7.5%">${ formatLang(line.product_uos and line.product_uos_qty or line.product_uom_qty) }</td>
214 <td style="text-align:center;">${ line.product_uos and line.product_uos.name or line.product_uom.name }</td>172 <td style="text-align:center;">${ line.product_uos and line.product_uos.name or line.product_uom.name }</td>
215 <td class="amount" width="8%">${formatLang(line.price_unit)}</td>173 <td class="amount" width="8%">${formatLang(line.price_unit)}</td>
216 <td style="font-style:italic; font-size: 10;">${ ', '.join([tax.description or tax.name for tax in line.tax_id]) }</td>174 <td style="font-style:italic; font-size: 10;">${ ', '.join([tax.description or tax.name for tax in line.tax_id]) }</td>
217 <td class="amount" width="10%">${line.discount and formatLang(line.discount, digits=get_digits(dp='Sale Price')) or ''} ${line.discount and '%' or ''}</td>175 <td class="amount" width="10%">${line.discount and formatLang(line.discount, digits=get_digits(dp='Sale Price')) or ''} ${line.discount and '%' or ''}</td>
218 <td class="amount" width="13%">${formatLang(line.price_subtotal, digits=get_digits(dp='Sale Price'))}&nbsp;${order.pricelist_id.currency_id.symbol}</td>176 <td class="amount" width="13%">${formatLang(line.price_subtotal, digits=get_digits(dp='Sale Price'))}&nbsp;${order.pricelist_id.currency_id.symbol}</td>
219 </tr>177 </tr>
220 %if line.formatted_note:178 %if line.formatted_note:
221 <tr class="line">179 <tr>
222 <td colspan="7" class="note" style="text-align:left;">${line.formatted_note| n}</td>180 <td class="formatted_note" colspan="7">
223 </tr>181 ${line.formatted_note| n}
224 %endif182 </td>
225 %endfor183 </tr>
184 %endif
185 %endfor
226 </tbody>186 </tbody>
227 <tfoot class="totals">187 <tfoot class="totals">
228 <tr>188 <tr>

Subscribers

People subscribed via source and target branches