Sales - Reports

Code review comment for lp:~camptocamp/sale-reports/7.0-conditional_discount_print-rde

  1. 7.0-conditional_discount_print-rde
  2. Merge into 7.0
Revision history for this message
Leonardo Pistone (lepistone) wrote :

Romain,

- lines seem a bit long to the naked eye
- you could catch only the exception you want to catch + a comment saying why you return False (i.e. "group does not exist)

thanks!

review: Needs Fixing (code review)

« Back to merge proposal