Code review comment for lp:~camptocamp/sale-financial/7.0-port-sale_line_watcher

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Yannick, several things:

- Instead of replacing a field, it's better to put position="attributes" and only overwrite attribute on_change, so that you don't replace another attributes of the field.

- I think it's better to use module web_context_tunnel to avoid changes on the signature of the method that provokes incompatibilities between modules.

Regards.

review: Needs Fixing (code review)

« Back to merge proposal