Code review comment for lp:~camptocamp/report-print-send/6.1-pingen

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Thanks for the fix!

About integer keys in the web client, that is odd given that this is used in Accounting -> Configuration -> Financial Accounting -> Account Reports -> Account Reports. The model of this action, account.financial.report contains the 'sign' field that has the following selection:

    [[-1,"Reverse balance sign"],[1,"Preserve balance sign"]]

But I ran a test and the problem is having an zero integer key, evaluating to false obviously somewhere in the client so that it shows no value at all in the dropdown. I'd say let's just leave it at this.

review: Approve

« Back to merge proposal