Purchase - Workflow and Organization

Code review comment for lp:~camptocamp/purchase-wkfl/7.0-add_framework_agreement-nbi

  1. 7.0-add_framework_agreement-nbi
  2. Merge into 7.0
Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote :

Hello,

thanks for the review

>
> I see 3 points:
>
> - integrity error on framework agreement deletion
As discussed a better message will be nice but nice to have.
>
> - import pdb in def open_agreement (maybe voluntary)>
Fixed
> - change price in a FA doesn't change price in existing purchase order lines,
> is it voluntary?
Yes but we should add a warning on change of price if related to a PO

Regards

Nicolas

« Back to merge proposal