Merge lp:~camptocamp/partner-contact-management/7.0-fix-partner_firstname-user-form into lp:~partner-contact-core-editors/partner-contact-management/7.0

[Yannick Vaucher @ Camptocamp]

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

l.39
    if not vals.get('name'):

review: Needs Fixing

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

l.56 I think that you have to use:
<attribute name="readonly" eval="False"/>

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

<attribute name="readonly" eval="False"/> fails.

As it is an attribute, I think it is ok to define it as a string.

[lp:~camptocamp/partner-contact-management/7.0-fix-partner_firstname-user-form]

18. By Yannick Vaucher @ Camptocamp on 2013-02-20

[IMP] partner_firstname - less steps in partner vals(e)

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

vals is fixed however launchpad failed to upload the diff...

I try to superseed the MP

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

LGTM

review: Approve (code review, no test)

Unmerged revisions

=== modified file 'partner_firstname/__openerp__.py'
--- partner_firstname/__openerp__.py	2013-02-05 08:26:54 +0000
+++ partner_firstname/__openerp__.py	2013-02-20 12:46:24 +0000
@@ -23,12 +23,15 @@
 
 The field 'name' becomes a stored function field concatenating lastname, firstname
 """,
- 'version': '1.0',
+ 'version': '1.0.1',
  'author': 'Camptocamp',
  'category': 'MISC',
  'website': 'http://www.camptocamp.com',
  'depends': ['base'],
- 'data': ['partner_view.xml'],
+ 'data': [
+     'partner_view.xml',
+     'res_user_view.xml',
+     ],
  'demo': [],
  'test': [],
  'auto_install': False,

=== modified file 'partner_firstname/res_user.py'
--- partner_firstname/res_user.py	2013-02-05 20:58:07 +0000
+++ partner_firstname/res_user.py	2013-02-20 12:46:24 +0000
@@ -1,4 +1,4 @@
-# -*- encoding: utf-8 -*-
+# -*- coding: utf-8 -*-
 ##############################################################################
 #
 #    Author: Nicolas Bessi. Copyright Camptocamp SA
@@ -27,5 +27,6 @@
     _inherit = 'res.users'
 
     def create(self, cursor, uid, vals, context=None):
-        vals['name'] = vals['login']
-        return super(ResUsers, self).create(cursor, uid, vals, context=context)
\ No newline at end of file
+        if not 'name' in vals or not vals['name']:
+            vals['name'] = vals['login']
+        return super(ResUsers, self).create(cursor, uid, vals, context=context)

=== added file 'partner_firstname/res_user_view.xml'
--- partner_firstname/res_user_view.xml	1970-01-01 00:00:00 +0000
+++ partner_firstname/res_user_view.xml	2013-02-20 12:46:24 +0000
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+  <data>
+    <record id="view_users_form" model="ir.ui.view">
+      <field name="name">res.users.form.firstname</field>
+      <field name="model">res.users</field>
+      <field name="inherit_id" ref="base.view_users_form"/>
+      <field name="arch" type="xml">
+        <field name="name" position="attributes">
+          <attribute name="readonly">False</attribute>
+        </field>
+      </field>
+    </record>
+  </data>
+</openerp>