Partner and Contact Management

Merge lp:~camptocamp/partner-contact-management/7.0-fix-partner_firstname-user-form into lp:~partner-contact-core-editors/partner-contact-management/7.0

  1. 7.0-fix-partner_firstname-user-form
  2. Merge into 7.0
Proposed by Yannick Vaucher @ Camptocamp
Status: Merged
Approved by: Guewen Baconnier @ Camptocamp
Approved revision: 18
Merged at revision: 17
Proposed branch: lp:~camptocamp/partner-contact-management/7.0-fix-partner_firstname-user-form
Merge into: lp:~partner-contact-core-editors/partner-contact-management/7.0
To merge this branch: bzr merge lp:~camptocamp/partner-contact-management/7.0-fix-partner_firstname-user-form
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp Approve
Review via email: mp+149573@code.launchpad.net

This proposal supersedes a proposal from 2013-02-20.

To post a comment you must log in.
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote : Posted in a previous version of this proposal

l.39
    if not vals.get('name'):

review: Needs Fixing
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote : Posted in a previous version of this proposal

l.56 I think that you have to use:
<attribute name="readonly" eval="False"/>

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote : Posted in a previous version of this proposal

<attribute name="readonly" eval="False"/> fails.

As it is an attribute, I think it is ok to define it as a string.

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote : Posted in a previous version of this proposal

vals is fixed however launchpad failed to upload the diff...

I try to superseed the MP

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

No available diff...

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote : Posted in a previous version of this proposal

LGTM

review: Approve (code review, no test)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

review: Approve

Subscribers

People subscribed via source and target branches

to status/vote changes: