Code review comment for lp:~camptocamp/partner-contact-management/7.0-add-firstname_display_name_trigger

Not sure it is relevant but in China, family name is the first to be
displayed.

For me it should be part of the localization or address setup
Eric CAUDAL

Eric Caudal
/CEO/
--
*Elico Corporation, Shanghai branch
/OpenERP Premium Certified Training Partner/ *
Cell: + 86 186 2136 1670
Office: + 86 21 6211 8017/27/37
Skype: elico.corp
<email address hidden> <mailto:<email address hidden>>
http://www.elico-corp.com

Elico Corp
On 06/18/2013 04:38 PM, Yannick Vaucher @ Camptocamp wrote:
> For the name_get function, it is a copy of official name_get but with few changes about constructing the name.
>
> The address concatenation where double \n are removed was taken from there. A cleanest way might be to ask for a hook to create the name.
>
> I also found the l.126-127 quite strange but I assume there are few chances that an address has more than 4 empty lines, even though it would be possible as there is no limit in country address format field.
>
> http://bazaar.launchpad.net/~openerp/openobject-server/7.0/view/head:/openerp/addons/base/res/res_partner.py#L524
>
> I'll check about Hidden category.