Code review comment for lp:~camptocamp/openobject-addons/trunk-refactor-po-merge-lep

Hi Olivier,

in general I agree with your remarks! I probably won't be able to fix that week, but I should next week. Let's just keep in touch so we don't do the same job twice :)

- on history management: it is a mistake, well spotted. I didn't want to change the behaviour.

- method signatures: a bit of a long discussion, and probably useless with the new API. Passing class instances instead of ids allows to easily write (isolated) unit tests like test_merge_origin_and_notes in this module. Here a mock is used, but the same approach can work with a real class instance. The same test for a method that accepts ids is more complex.

thanks!