Merge lp:~camptocamp/openobject-addons/trunk-fix_mail_auto_subscribe-1188538 into lp:openobject-addons

[Guewen Baconnier @ Camptocamp]

[FIX] automatically subscribe users from fields even if the field has no 'track_visibility' defined.

This condition prevented to register new fields given in the 'auto_follow_fields' arguments if they had no 'track_visibility', which is unrelated to the automatic subscription

fix lp:1188538

[Martin Trigaux (OpenERP) (mat-openerp)]

As mentioned on the bug report, not the behaviour we would like to have.
I reject this merge proposal then

Regards

Unmerged revisions

8755. By Guewen Baconnier @ Camptocamp on 2013-06-07

[FIX] automatically subscribe users from fields even if the field has no 'track_visibility' defined.

This condition prevented to register new fields given in the 'auto_follow_fields' arguments if they had no 'track_visibility', which is unrelated to the automatic subscription

=== modified file 'mail/mail_thread.py'
--- mail/mail_thread.py	2013-06-05 09:04:53 +0000
+++ mail/mail_thread.py	2013-06-07 09:42:28 +0000
@@ -1342,7 +1342,6 @@
             trigger an auto subscribe. The default list checks for the fields
             - called 'user_id'
             - linking to res.users
-            - with track_visibility set
             In OpenERP V7, this is sufficent for all major addon such as opportunity,
             project, issue, recruitment, sale.
             Override this method if a custom behavior is needed about fields
@@ -1350,7 +1349,7 @@
         """
         user_field_lst = []
         for name, column_info in self._all_columns.items():
-            if name in auto_follow_fields and name in updated_fields and getattr(column_info.column, 'track_visibility', False) and column_info.column._obj == 'res.users':
+            if name in auto_follow_fields and name in updated_fields and column_info.column._obj == 'res.users':
                 user_field_lst.append(name)
         return user_field_lst