Merge lp:~camptocamp/openobject-addons/7.0-fix_action_rule_processing_lp1190592-afe into lp:openobject-addons/7.0
Proposed by
Alexandre Fayolle - camptocamp
Status: | Needs review |
---|---|
Proposed branch: | lp:~camptocamp/openobject-addons/7.0-fix_action_rule_processing_lp1190592-afe |
Merge into: | lp:openobject-addons/7.0 |
Diff against target: |
17 lines (+6/-1) 1 file modified
base_action_rule/base_action_rule.py (+6/-1) |
To merge this branch: | bzr merge lp:~camptocamp/openobject-addons/7.0-fix_action_rule_processing_lp1190592-afe |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Leonardo Pistone (community) | code review | Approve | |
OpenERP Core Team | Pending | ||
Review via email: mp+209077@code.launchpad.net |
Description of the change
Fix base.action.rule is repeated ignoring the date it was last run (lp:1190592)
I think this fix is more readable than the version proposed in https:/
To post a comment you must log in.
Unmerged revisions
- 9860. By Alexandre Fayolle - camptocamp
-
[FIX] base.action.rule is repeated ignoring the date it was last run
Thanks Alexandre,
I completely agree with you the original one-liner is unreadable (I remember spending a while to figure it out at the time).
The reason for the old proposal was to just fix the bug, without trying to improve the code.
So if it were new code, I'd be 100% approve, for a fix like that I don't know.