Code review comment for lp:~camptocamp/openobject-addons/6.0-fix-l10n_ch-20110914

Revision history for this message
xrg (xrg) wrote :

From the very first quick look I had at the diff:

=== ....
=== modified file 'l10n_ch/sample/README' (properties changed: -x to +x)
=== modified file 'l10n_ch/sample/sample.dta' (properties changed: -x to +x)
=== modified file 'l10n_ch/sample/sample.v11' (properties changed: -x to +x)
=== modified file 'l10n_ch/sample/zvr_besrtechdok_fr.pdf' (properties changed: -
x to +x)
.... etc.

Please, do not turn on the executable bit on data files. It produces errors
when trying to package OpenERP.

Also, if you are including files from other python projects, please be prepared
to answer:
 - are these files just standalone, or part of any other python "library"? In
the second case, why not call this library instead of copying (bundling) the
file?
 - what is the copyright of the files? License, distribution policy?

--
Say NO to spam and viruses. Stop using Microsoft Windows!

« Back to merge proposal