Code review comment for lp:~camptocamp/openerp-reporting-engines/7.0-add-base_report_assembler-yvr
Revision history for this message
| Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Thanks that's a nice module.
Besides the changes requested above, I would just propose to replace the french translation "Companie" (misspelled BTW) by "Société" as this word is used usually.
Can you rename the argument "cursor" to "cr" where it occurs?
l.283,293: needs """ for docstring