Code review comment for lp:~camptocamp/openerp-product-attributes/7.0-product_images-migr
Revision history for this message
| Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Updated the proposal taking into account your comments.
Still, I don't see cases where we are garanteed that 'name' and 'extension' are in the vals.
When we do a create(), we are able to call it without any of them ('name' is mandatory, so the call to super() will raise an exception, but it should not crash because of the key error).
When we do a write(), we can call it without a 'name' or an 'extension' or any of them.