Code review comment for lp:~camptocamp/oerpscenario/trunk-set-context-lep

Revision history for this message
Leonardo Pistone (lepistone) wrote :

I addressed Nicolas' remarks.

As for the Alexandre's comments, they are not done yet, because a cleaner solution could be to do that in erppeek and not in oerpscenario. See

https://github.com/tinyerp/erppeek/issues/40

So for now I could leave this MP as is, since it does what I need now (pass a context to create()) and then maybe adapt it when the new erppeek feature lands.

Thanks!

« Back to merge proposal