Code review comment for lp:~camptocamp/oerpscenario/trunk-set-context-lep

Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote :

Hello,

little fix in inline comments.

The only point that tickle me is that I'm not sure of the lifespan of ctx.
It may be dangerous if we do not reset it.

I would add a hook at Scenario initialization to reset it to {}.

review: Needs Fixing

« Back to merge proposal