Code review comment for lp:~camptocamp/oerpscenario/fix-create-db-odoo-8

Revision history for this message
Leonardo Pistone (lepistone) wrote :

1. you could take the occasion to refactor the original code in

admin_login_password = xxx.get('yyy') or 'admin'

and remove the "if" block

2. the commit message is unclear to me, you mean "do NOT log user in" ?

3. the new commentary sound also a bit obscure but maybe it's only me :)

4. not 'no_login' in -> 'no_login' not in

thanks

review: Needs Fixing

« Back to merge proposal