Code review comment for lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi

Revision history for this message
Laurent Mignon (Acsone) (lmi) wrote :

Too late... but I've the feeling that the code will break existing installations on the second call to the upgrade method of the module. The init method is called each time the module is upgraded. IMO, this kink of logic should be put in a post-migration script.
What's happening if you execute 2 times the command 'start_openerp -u all' on a existing database with the module installed? I think that the passwords will be encrypted 2 times.
Hope I'm wrong...

review: Disapprove

« Back to merge proposal