Code review comment for lp:~camptocamp/ocb-addons/7.0-webkit_report-image_helper-20130318
Revision history for this message
| Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
It shouldn't create incompatibility as the added argument "unit" is optional and if unset, it will be "px" still.
In my opinion, this will only make it available and we can make other webkit exemple header keeping the pixel sizes.
In fact, it will be useful for real custom reports, we do not care to have it yet example reports.
When you use webkit and set your logo you will have to create your own specific header and at that time you should be able to use a metric unit.
If you receive some corporation identities rules it will be in mm or cm and as you have only pixels, you will be cursing developers for each tries of conversion convert from cm to pixels.
So for the sake of developers who don't want to be haunted during there dreams, this should be accepted.