Code review comment for lp:~camptocamp/margin-analysis/7.0-port-product_historical_margin-xml-retab-yvr
Revision history for this message
| Ronald Portier (ronald-portier) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
I also vote for 2 spaces.
Also please: if there is more then one attribute, have each attribute on a new line.
(Unfortunately OpenERP will break if you spread attributes over multiple lines, even where this would be perfectly logical, as with long domain expressions).
Having each attribute on a new line will make changes much more "diff friendly". if you change one attribute, instead of having to scan a very long line where exactly anything changed, this will be immediately obvious.